tests: update yang-library results in oper testsNeed to add frr-host to the expected results when yang-library oper-state is
checked.
Signed-off-by: Christian Hopps <chopps@labn.net>
lib: add FRR_MGMTD_BACKEND flag and set it appropriatelyFirst use of flag is to decide whether to initialize the `host` CLI handlers
in the daemon or not.
Mgmtd daemons process `frr-host` config from mgmtd which handles the CLI, others
still take it directly from VTY and so they need the DEFPY handlers.
Signed-off-by: Christian Hopps <chopps@labn.net>
lib: add northbound support for frr-host YANG module- Everyone loads frr-host module to process host config
Signed-off-by: Christian Hopps <chopps@labn.net>
babeld: Convert all code to use our code formatting rulesThe babeld code was originally kept in a non-standard
format, at least to how FRR formats code, because the
code came from outside the project and it was hoped
that updates would be coming from the originators.
That has not turned out to be true and we've been slowly
getting bug-fixes for the code over the last year
as it is being used. Let's just bite the bullet
and convert over to our intern...
lib: error may be null so don't dereferror may not be passed in, all other paths
that use error already check to ensure that
it is non-null. Add this one too.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests: Use more complicated topology to show how NHC worksInclude multipath networks with NHC attribute.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
tests: add new /run/netns tmpfs to each topotest router namespaceThis is required for correct parallel execution when tests add new namespaces
with `add_netns()` which uses `ip netns add` command which tracks them using
`/run/netns`.
Signed-off-by: Christian Hopps <chopps@labn.net>
bgpd: Fix crash when fetching statistics for bgp instanceWhen running `show bgp view all ipv4 unicast statistics json` and bgp is NULL,
do not crash it and instead iterate over the all instances and put stats
accordingly.
Fixes: https://github.com/FRRouting/frr/issues/18982
Fixes: 1115feedc3f878853e2e67df9efdd0f5e5e1f997 ("bgpd: add some counters not displayed yet")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Merge pull request #18993 from opensourcerouting/fix/bgp_crash_attributes_too_longbgpd: Do not reuse the same adj->adv when flushing fifo (attributes too long)
bgpd: Clean up evpn mac hash on shutdown.The bgp evpn mac hash was not properly cleaning
up on shutdown. Make it so.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
lib: Fix impossible situation with first variablefirst is always true for the first if statement. As such
we do not need to take it into account. Makes coverity happy,
plus the note if someone comes in and changes things around
they can fix it up right.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: Do not reuse the same adj->adv when flushing fifo (attributes too long)2025/04/24 22:46:35 BGP: [N463T-4M950][EC 33554449] u4:s4 attributes too long, cannot send UPDATE
BGP: Received signal 11 at 1745523995 (si_addr 0x30, PC 0x55f988339d30); aborting...
BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(zlog_backtrace_sigsafe+0x6f) [0x7f9ba3aca4cf]
BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(zlog_signal+0xf5) [0x7f9ba3aca6d5]
BGP: /usr/lib/x86_64-linux-gnu/frr/libf...
Merge pull request #18930 from opensourcerouting/fix/ll_capability_no_notificationbgpd: Don't send notification if IPv6 Link-Local is not assigned on the interface
yang: Fix pyang errors in frr-pim-rp.yangfrr-pim-rp.yang:79: error: RFC 8407: 4.13,4.14: statement "typedef" must
have a "description" substatement
frr-pim-rp.yang:126: error: RFC 8407: 4.14: statement "grouping" must
have a "description" substatement
frr-pim-rp.yang:137: error: keyword "description" not in canonical
order, expected "type" (see RFC 7950, Section 14)
frr-pim-rp.yang:138: error: keyword "type" not in canonical order (se...
Merge pull request #18967 from donaldsharp/allow_connecting_overlapping_in_another_tablezebra: Allow routes that could be considered connected to exist
zebra: Allow routes that could be considered connected to existIf you have a kernel route that would normally be considered
as connected, allow it to exist in non vrf table-ids as well
as the non-default table.
Fixes: #18952
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: Set atomic aggregate attribute if we drop AS_SETsrfc9774 says that:
The ATOMIC_AGGREGATE Path Attribute is subsequently attached to the BGP route,
if AS_SETs are dropped.
Fixes: 925b365a87f21f29c9b1378cae468b2f989c346f ("bgpd: Do not advertise aggregate routes to contributing ASes")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donald Sharp
Christian Hopps
anlan_cs
Donald Sharp
Y Bharath