Merge pull request #20281 from opensourcerouting/fix/bgp_sw_version_and_fqdn_capabilitybgpd: Do not send software-version capability if it's disabled explictly
tests: test regression with failed config backend restart failing- multiple backends invalidating (failing) config it leads to ships in the night
txn-deletes from mgmtd (i.e., the daemons sending cfg error and deleting the txn
at the same time mgmtd is sending txn delete for that same txn). Getting a
delete for a non-existent txn was causing the backend to reset the connection.
- the backend that mgmtd processed for failure also was told to txn-delete
leadi...
bgpd: Send route-refresh and/or trigger soft reconfig on enforce-first-asIf we use `neighbor X enforce-first-as`, we trigger route-refresh and soft
reconfiguration. We should do the same for a global knob too.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
lib: darr: zero new elms when an darr is extended with darr_ensure_i- Add a test to verify correct behavior.
Signed-off-by: Christian Hopps <chopps@labn.net>
doc: update doc to reflect client data only in client now.- the client data moved out of mgmtd so document the correct way to inform
mgmtd of that data now at client creation time.
Signed-off-by: Christian Hopps <chopps@labn.net>
Merge pull request #20322 from opensourcerouting/fix/treat-as-withdraw-if-lenghts-are-conflictingbgpd: Treat as withdraw iBGP session when total attr length is path attributes
bgpd: peer_create now accepts the connection directionModify peer_create to take a connection direction and to
pass it on appropriately.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: Allow peer_connections to take a connection directionOn connection creation, specify a connection direction.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: [TP] Traces in Zebra netlink parse error conditionsAdding traces in Zebra netlink parse error conditions
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Zebra EVPN operationsAdding traces in Zebra EVPN operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in VTEP operationAdding traces in Zebra VTEP operation
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in NHG operationsAdding traces in Zebra NHG operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Route or Rib operationsAdding traces in Zebra Route/Rib operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
lib: Add Nexthop status in nexthop2str functionAdd Active/Inactive Nexthop status in nexthop2str function
Ticket :# 4265339
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Intf managementAdding traces in Zebra Intf management
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
topotests: add bgp as-path-limit match testAdd a test in bgp_remove_private_as test suite.
it checks that it is possible to filter out route and path
based on the as-path-limit match operation of the
route-map.
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
bgpd: add 'match as-path-count' command to restrict AS path countAdd a mechanism in route-map to filter out routes that has a paths
greater than the given number.
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
mgmtd: remove client specific data from mgmtd- Clients send this same data in their subscribe message, so do so.
- Avoids conflicts when doing source management (e.g., adding/removing clients).
Signed-off-by: Christian Hopps <chopps@labn.net>
bgpd: Treat as withdraw iBGP session when total attr length is path attributesRFC 7606 says:
Attribute Length Fields
There are two error cases in which the Total Attribute Length value
can be in conflict with the enclosed path attributes, which
themselves carry length values:
* In the first case, the length of the last encountered path
attribute would cause the Total Attribute Length to be exceeded
when parsing the enclosed path attributes.
...
tests: Add a test_ospfv3_route_map_forwarding testThe route-map set command `set forwarding-address X::X`
in ospf6d has a bug where this was not correctly being
honored. Let's write a topotest that shows that this
fix works and is correct.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ospf6d: Route-Map parameter forwarding-address functionality not working properlyIssue:
The forwarding-address parameter set via a route-map is not being reflected
in the OSPFv3 LSAs as expected.
Specifically, after configuring the following on router L1,
the forwarding-address is missing from the OSPFv3 database
on the peer router S1:
Root Cause:
In the function ospf6_asbr_redistribute_add,
the forwarding address is initially set from the route-map:
if (!IN6_IS_ADDR_UNSPE...
zebra: Add counter for ND router solicitations receivedAdd a counter to track the number of IPv6 ND Router Solicitation
messages received on each interface. Display this counter output for
"show interface <inf name> [json]" command.
Ticket: #4125781
Testing:
r1# show interface swp3
Interface swp3 is up, line protocol is up
Link ups: 0 last: (never)
Link downs: 0 last: (never)
PTM status: disabled
vrf: default
index 5 met...
bgpd: Allow LL peering to update v6 GUACurrently, when a LL based peer in BGP is created:
neighbor fe80:1::1 remote-as external
neighbor fe80:1::1 interface r2-eth0
When the interface is updated with a v6 GUA after
peering is established. The v6 GUA is never sent to the
peer.
Current code behavior allows for bgp unnumbered peering:
neighbor r2-eth1 remote-as external
To update it's GUA address when it comes the address i...