bgpd: fix incorrect 'tmp_prefi' variable nameThe chosen name was a typo error from the beginning. Use tmp_prefix
instead.
Fixes: d79ff732cdcd ("bgpd: handle srv6 locator notification and update vpn-rib")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
lib: fix reset static buffer when reading sid notify locatorTwo consecutive SID notifications for the same L3VRF, but with locators
with similar naming; the second notification may fail. The below srv6
configuration:
> segment-routing
> srv6
> locators
> locator dmytro
> prefix 2002:db8:1:1::/64
> exit
> !
> locator dmytro2
> prefix 2004:db8:1:1::/64
> exit
SID retrieval from BGP may result in a flooding of allocation/release...
bgpd: fix log trace to replace mpls keyword with sidChange a log trace that should deal with SID instead of label.
Fixes: 831b825b895f ("bgpd: Release SIDs when disabling SRv6 in BGP")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
mgmtd: vty_terminate() before client cleanup- Need to vty_terminate() (i.e., vty_close our vtys) before we cleanup the mgmt
client sessions associated with those vtys. vty_terminate() is normally done in
frr_fini(), but we also need to do our client cleanup before calling frr_fini()
as we need the event system still initialized and frr_fini() cleans it up.
Signed-off-by: Christian Hopps <chopps@labn.net>
bgpd: fix do not call bgp_srv6_unicast_withdraw() when unnecessarySimplify the call to bgp_srv6_unicast_withdraw in sid_notify function,
as this call is not relevant when DT46 sid is received.
Fixes: 0e1ec43c5802 ("bgpd: announce bgp srv6 unicast")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
bgpd: add missing afi value in debug when withdrawing a sidAdd the sid AFI value that is being removed in the traces.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Merge pull request #20281 from opensourcerouting/fix/bgp_sw_version_and_fqdn_capabilitybgpd: Do not send software-version capability if it's disabled explictly
tests: test regression with failed config backend restart failing- multiple backends invalidating (failing) config it leads to ships in the night
txn-deletes from mgmtd (i.e., the daemons sending cfg error and deleting the txn
at the same time mgmtd is sending txn delete for that same txn). Getting a
delete for a non-existent txn was causing the backend to reset the connection.
- the backend that mgmtd processed for failure also was told to txn-delete
leadi...
bgpd: Send route-refresh and/or trigger soft reconfig on enforce-first-asIf we use `neighbor X enforce-first-as`, we trigger route-refresh and soft
reconfiguration. We should do the same for a global knob too.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
lib: darr: zero new elms when an darr is extended with darr_ensure_i- Add a test to verify correct behavior.
Signed-off-by: Christian Hopps <chopps@labn.net>
doc: update doc to reflect client data only in client now.- the client data moved out of mgmtd so document the correct way to inform
mgmtd of that data now at client creation time.
Signed-off-by: Christian Hopps <chopps@labn.net>
Merge pull request #20322 from opensourcerouting/fix/treat-as-withdraw-if-lenghts-are-conflictingbgpd: Treat as withdraw iBGP session when total attr length is path attributes
bgpd: peer_create now accepts the connection directionModify peer_create to take a connection direction and to
pass it on appropriately.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: Allow peer_connections to take a connection directionOn connection creation, specify a connection direction.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: [TP] Traces in Zebra netlink parse error conditionsAdding traces in Zebra netlink parse error conditions
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Zebra EVPN operationsAdding traces in Zebra EVPN operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in VTEP operationAdding traces in Zebra VTEP operation
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in NHG operationsAdding traces in Zebra NHG operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Route or Rib operationsAdding traces in Zebra Route/Rib operations
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
lib: Add Nexthop status in nexthop2str functionAdd Active/Inactive Nexthop status in nexthop2str function
Ticket :# 4265339
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
zebra: [TP] Traces in Intf managementAdding traces in Zebra Intf management
co-authored by Nvidia FRR team
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
Donald Sharp
Bing Shui
Y Bharath
Philippe Guibert
Christian Hopps
Yusho Yamaguchi
Donald Sharp
Rajasekar Raja