isisd: Fix fortify abort by simplifying lsp_bits2stringThe lsp_bits2string function was incorrectly passing the total buf_size
to subsequent snprintf calls instead of the remaining buffer space.
This caused the compiler's _FORTIFY_SOURCE security checks to trigger a
SIGABRT, as the requested write size exceeded the bounds of the buffer.
This issue was exposed after switching the compiler from GCC to Clang
on Ubuntu 24.04.
Instead of fixing the po...
Merge pull request #20957 from opensourcerouting/fix/bgp_use_prep_for_rmap_apply_before_route_map_applybgpd: Reuse prep_for_rmap_apply() before route_map_apply()
bgpd: Reuse prep_for_rmap_apply() before doing route_map_apply()Just to make sure we initialize everything correctly.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd: Fix test for OPEN message with remote-as autoIf we already have a remote-as auto, and it was implicitly set to _external_,
and another side is changing an AS number to be identical to ours (internal),
we should set/unset appropriate flags for as_type.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd: Add missing PEER_FLAG_SEND_NHC_ATTRIBUTE for update group flagsWithout this flag if we have an established connection and the peer-group is
already created it's going to have a missing flag for comparing when to send
NHC attribute or not.
This fixes random failures for bgp_nhc topotest.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
lib: display End.DX2 route with appropriate oif attributeWithout that change, no extra attribute is associated to that SRv6
instruction.
> ip route add 2001:db1::/48 encap seg6local action End.DX2 oif dum1 dev loop1
>
> PE1# show ipv6 route
> Codes: K - kernel route, C - connected, L - local, S - static,
> R - RIPng, O - OSPFv3, I - IS-IS, B - BGP, N - NHRP,
> T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
> F - PBR, ...
tests: Add a topotest for MSDP SA forwardingTest case hits SA forwarding between an MSDP mesh-group and two MSDP
peers.
Signed-off-by: Lewis Chambers <lewis.p.chambers@hotmail.com>
doc: add multicast testing guide for topotestsAdd documentation for multicast testing in FRR topotests:
- Three methods for multicast testing:
- direct scripts (mcast-tx.py/mcast-rx.py)
- unified tester (mcast-tester.py)
- helper class (McastTesterHelper)
- When to use each method and their respective features
- Code examples and best practices
- References to existing test files that demonstrate each approach
Signed-off-by: Jafar ...
eigrpd: handle the gr neighbor list safely in update_receiveBe careful handling the gr neighbor list; don't free the
list if it's present in the neighbor struct.
Reported-by: Sin Liang Lee <slee3846@gatech.edu>
Signed-off-by: Mark Stapp <mjs@cisco.com>
nhrpd: fix packet and buffer handling errorsFix some buffer-handling errors in nhrp.
Reported-by: Sin Liang Lee <slee3846@gatech.edu>
Signed-off-by: Mark Stapp <mjs@cisco.com>
bgpd: fix wrong stopping the listening portAfter removing all neighbors from default bgp instance, the listening
port is wrongly stopped.
Fixes commit df7b1910abeedc822343643ac626b6fc84021f9d ("bgpd: Activate listening socket for a default VRF when created")
Signed-off-by: anlan_cs <anlan_cs@126.com>
bgpd: fix missing starting listening portThe listening port also needs to be activated for the interface neighbor, as well
as for the normal neighbor.
Fixes: f8dafef42b694de723df256765df37f8405ef48e ("bgpd: avoid socket activation for VRF instances")
Signed-off-by: anlan_cs <anlan_cs@126.com>
bgpd: correct the display headerUse macro for the display header, just as it is used in other places as well.
Signed-off-by: anlan_cs <anlan_cs@126.com>
tests: fix a regex in all_protos topotestAllow a regex to tolerate a negative value; remove a duplicated
statement.
Signed-off-by: Mark Stapp <mjs@cisco.com>
yang: Revision statements are not given in reverse chronological order at frr-staticd.yangRevision stements are not given in reverse chronological order at frr-staticd.yang
Signed-off-by: y-bharath14 <y.bharath@samsung.com>
tests: Test the new output for `show neighbor'Update the test that looks at the neighbor table
to look for the state value as well now and to
use json and finally to use run_and_expect
as that it will fail.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: Store state of the neighbor entryStore the state of the neighbor entry and display it
as appropriate.
eva# show neigh
Interface Neighbor MAC #Rules State
enp13s0 192.168.119.120 00:e0:67:21:d5:88 0 REACHABLE
enp13s0 fd5d:a247:468e:10::1 26:5a:4c:59:da:3d 0 REACHABLE
Signed-off-by: Donald Sharp <sharpd@nv...
zebra: Properly break up `show ip neigh``show ip neigh` currently dumps the entire neighbor table,
which of course includes both v4 and v6 neighbor entries.
Modify the code to have `show ip neigh` just dump the v4
neighbor entries.
Add a `show ipv6 neigh` and a `show neighbor` command that
dumps what you would expect.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald Sharp
Renato Botelho do Couto
Donatas Abraitis
Philippe Guibert
Lewis Chambers
Mark Stapp
anlan_cs
Christian Hopps
Y Bharath
Donald Sharp