zebra: free nl batch buffer on terminationThe nl batch buffer was destroyed too early when a netns was
terminated. Now freeing the buffer later in router_terminate allows
netlink messages to be still processed.
Signed-off-by: Christopher Dziomba <christopher.dziomba@telekom.de>
*: Allow returns to work with --enable-undefined-behaviorIf you have undefined behavior compilation checking gcc
starts to complain about a bunch of places that do not
have return's. When most of them actually do and we
have the assert's to prove it. I'm just doing this
to make the compiler happy for me, so I can continue
to do work.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
topotests: add evpn vrf route leaking testAn additional VRF, 102, is introduced on both routers, importing
r1 routes from VRF 101 into VRF 102 on r2 and vice versa (both
on r2, because r1 is in netns mode and can not use route import).
RMACs and ping (from VRF 101 to VRF 102 on r1, going through r2) is
then checked.
All RMACs are created deterministically, using
52:54:00:00:<router>:<vrf> to ease debugging and checks.
Signed-off-by:...
zebra: use nexthop instead of route vrf_id for EVPNToday zebra tracks EVPN vtep_ips in the L3-VNI of the route_entry.
Leaking routes in bgpd and using different RMACs on the remote side
for different L3-VNIs for a single VTEP leads to updates in the leak
destination VRF which is not desired. Zebra gets the source VRF in
vrf_id of the nexthops. This nexthop vrf_id is now used for adding/
updating/deleting the l3vni nexthop.
Signed-off-by: Chris...
zebra: Change zserv_accept to use global zsock FDProblem:
Zebra crashed while going down. This happened because zebra was
trying to process a new client accept request after closing ZAPI's
listener socket zsock and setting it to -1.
Fix:
Skip rescheduling zserv_accept() and accepting a new client if global
ZAPI listener socket FD, zsock is already closed and set to -1.
Also use global ZAPI listener socket FD zsock in zserv_accept() instead
o...
*: expose and clean up 'noreturn' functionsEnable the -Wmissing-noreturn warning, and resolve warnings
for gcc and clang. Add a FRR_NORETURN macro and use that for
the new changes.
Signed-off-by: Mark Stapp <mjs@cisco.com>
tests: bgp_evpn_rt5 test match evpn vni0d5bd461af commit was supposed to check that route-map "match evpn vni"
was working by adding a r3 router that injected prefixes with VNI 102.
A route-map on r1 was filtering r3 prefixes. However, the test was
working even after removing r3. A check was needed without the route-map
to check that r3 prefixes were received before applying the filter.
Test "match evpn vni" route-map filtering app...
tests: bgp_evpn_rt5 rename router variablesin order to identify which router we are talking about.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
tests: bgp_evpn_rt5 reformat configuration commandsReformat configuration commands in human readable style.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
tests: bgp_evpn_rt5 re-address rd and rtRe-address Route-Distinguisher and route-targets for clarity.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
docker: add ssmping to the the ubuntu docker imagesssmping is missing from our docker builds. Let's add
it so that topotests can run correctly.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Christian Hopps <chopps@labn.net>
tests: Add a simple ssmping test to the systemThere are no tests that attempt to cover the ssmpingd
functionality in pimd. Add a very very simple test case.
This test requires the ssmping package to be installed.
Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
tests: Convert pim_basic to use integrated configurationSince I am in this test, modifying it let's just convert
it to a integrated configuration.
Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
pimd: Allow ssmpingd command to work for pimCommit: 1c56018f66723a5ea478f0d6607a8f81f4d6ada5
broke the ssmpingd implementation in pim. This
is because it just completely botched the bind
to the correct port and address.
Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
zebra: Display nhg's afi as `No Afi`When displaying `show nexthop-group rib` the afi
displayed for Nexthop Groups ( not singletons ) is
`bad-value` which while true to the specific of
the AFI it's not necessarily what we want to display
to the end operator. Add a wrapper function for
nhg's to do the right thing.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
pimd: Fix for crash during networking restartDuring vrf delete, the vxlan_info.work_list
linked list was deleted which is a global list
containing the SGs for all the VRFs.
If two vrfs are configured, vrf a and vrf b and
both has SGs assocaited with them which are
inserted in the vxlan_info.work_list. Now if
vrf a is deleted, it deletes the work_list also.
Due to this when any SG add or del comes for vrf b
it tries to access the work_lis...
doc: line vty was not documentedTry to document the sub-node `line vty` and
what it can do. Call out the distinction
between vtysh and VTY.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests: remove ipv4 and ipv6 in bgp_evpn_rt5Removal of IPv6 was already tested in bgp_evpn_rt5 topotest, however
IPv4 was not tested afterwards. This now removes IPv6 routes first,
then adds them back and removes IPv4 afterwards, waiting for
convergence everytime.
Signed-off-by: Christopher Dziomba <christopher.dziomba@telekom.de>
zebra: add vtep_ip to rmac nh_list in all caseszebra rmac has a nh_list which tracks the assigned VTEP IPs to RMACs.
It can also receive IPv6 encoded IPv4 addresses as VTEPs. Changing/
Installing the RMAC into the Kernel is only important when the IPv4
address changes. However because nh_list is a nodup list used to
track usage or RMACs by VTEP IPs, both IP addresses (IPv4 and IPv6
encoded IPv4) should be written into it, as both could be r...
Philippe Guibert
Christopher Dziomba
Donald Sharp
Y Bharath
Pooja Jagadeesh Doijode
Mark Stapp
Louis Scalbert
Donald Sharp
Valentin Binotto