lib: Relax usage of `ip prefix-list A.B.C.D/M ge Y`Currently the prefix length M must be less than Y.
Relax this restriction to allow M to be less than or equal
to Y.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: Fix use after free in debug pathWhen zebra is running with debugs turned on there
is a use after free reported by the address sanitizer:
2020/10/16 12:58:02 ZEBRA: rib_delnode: (0:254):4.5.6.16/32: rn 0x60b000026f20, re 0x6080000131a0, removing
2020/10/16 12:58:02 ZEBRA: rib_meta_queue_add: (0:254):4.5.6.16/32: queued rn 0x60b000026f20 into sub-queue 3
=================================================================
==31014...
bgpd: Use bgp_dest_get_prefix accessor functionUse the appropriate bgp_dest_get_prefix accessor function
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: More bgp_node -> bgp_dest cleanupSome more of the bgp_node usage snuck in from big commits in
the past month or so from feature work. Do some work
to put it back to bgp_dest for incoming future work.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd: Convert to %pFX or %pBD where possibleSearch and destroy places where we used prefix2str
that could be replaced with %pFX or %pBD in bgpd.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
sharpd: Fix nexthop group name collisionIf you have two nexthop groups named
one
oneone
then the sharp daemon will treat them as the same nexthop
group. This is because we are doign this:
static int sharp_nhg_compare_func(const struct sharp_nhg *a,
const struct sharp_nhg *b)
{
return strncmp(a->name, b->name, strlen(a->name));
}
The strlen should be the size of the array of name.
Signed-...
tests: fix spurious failures in the TI-LFA topotestSkip comparing neighbor-extended-circuit-id in yang output. They
are not consistent.
This is similar to commit ecc11c93b7eace which fixed the same
problem in the IS-IS SR topotest.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
lib: align prefixevpn2str output with bgp_evpn_route2strWe have 2 different routines to turn an evpn route into a string.
This commit aligns the two to the latest maintained version as a
first step in removing one of them.
Signed-off-by: Pat Ruddy <pat@voltanet.io>
ospfd: fix invocation of ospfTrapNbrStateChangeospfNbrStateChange is generated when the state of neighbor regresses or
it progresses to a terminal state. When transitioning to or from Full
state on non-broadcast multi-access and broadcast networks the trap
should be sent by the designated router. This last condition was not
taken into account when checking for the conditions of generating the
trap.
Fixes volta/volta-stack#1811
Signed-off-...
isisd: fix check for area-tag modificationInterface area-tag is not supposed to be modified once defined, but the
necessary check is currently broken, because the circuit is never in
init_circ_list if the area-tag is already configured for the interface.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
isisd: add support for Topology Independent LFA (TI-LFA)TI-LFA is a modern fast-reroute (FRR) solution that leverages Segment
Routing to pre-compute backup nexthops for all destinations in the
network, helping to reduce traffic restoration times whenever a
failure occurs. The backup nexthops are expected to be installed
in the FIB so that they can be activated as soon as a failure
is detected, making sub-50ms recovery possible (assuming an
hierarchi...
ospfd: make reason string production saferUse to-string functions for GR message codes instead of raw
string array indexing; the values used can come in packets
and are not validated.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
ospfd: Store neighbor Adjacency SID in SR databaseFor TI-LFA, it is necessay to known the Adjacency SID advetise by the nieghbor
routers. However, the current Segment Routing code skip neighbor Adjacency SID
and thus, don't store them into the Segment Routing database.
This PR takes care of neighbor Adjacency SID by allowing to store them in the
Segment Routing database. Corresponding MPLS table entry is only configured if
the advertised Adja...
*: Consolidate on first git blame ignore revsThe file .git-blame-ignore-revs was put first into
the system and is what was advertised in multiple
places. Since .ignore-revs was just created and
no announcement was made about the creation, let's
consolidate onto the first one created.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: Isolate mlag_rd_buf_offset to the actual using functionIsolate the mlag_rd_buf_offset variable to the actual used function,
instead of having it a global.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donatas Abraitis
Donald Sharp
Renato Westphal
Pat Ruddy
Babis Chalios
Igor Ryzhov
Mark Stapp